[7u10] Request for approval: 7112670: Inet4AddressImpl should use getaddrinfo/getnameinfo (original) (raw)

Shi Jun Zhang zhangshj at linux.vnet.ibm.com
Wed Sep 19 00:07:55 PDT 2012

On 9/19/2012 2:07 AM, Seán Coffey wrote:

Shi Jun,

as per reviewer comments, this change may bring some compatibility issues to an update release. It may be best to raise a new discussion on net-dev alias if you want to push ahead with porting to 7u. Once you've cleared this with net-dev you can seek 7u approval again. regards, Sean. On 17/09/2012 11:29, Chris Hegarty wrote: On 17/09/2012 10:06, Alan Bateman wrote:

For the record, I have concerns about back-porting this to 7u. The reason is that switching to getnameinfo and getaddrinfo can result in subtle behavioral changes that cause problems for applications and developers. A recent one in this area was: http://bugs.sun.com/viewbug.do?bugid=7166687 where the Mac port changed 7u4 to use getnameinfo, it was switched back in 7u5 to restore previous behavior. I realize the changes you are looking to back port are for the IPv4 case and maybe there are people running with IPv6 disabled but I think we need to fully understand any behavior changes before this is considered for a 7u release. I agree with Alan here, while this is a nice cleanup it may bring a change in behavior. If this backport is trying to address a specific issue you are running into, then we should investigate further any potential compatibility issues. Otherwise, it may be best to simply not backport in this case. -Chris.

-Alan.

On 17/09/2012 09:14, Shi Jun Zhang wrote: Hi all, I'd like to request for approval to push the following change into 7u10. Changeset in jdk8 http://hg.openjdk.java.net/jdk8/tl/jdk/rev/81987765cb81 Webrev http://cr.openjdk.java.net/~zhangshj/jdk7u/7112670/webrev.00/ Reviewed by chegar, alanb, mduigou, ngmr Review thread http://mail.openjdk.java.net/pipermail/net-dev/2011-November/003702.html

Thanks Sean, Chris and Alan.

I think the bug Alan mentioned is just a typo by Mac porting but not because of using getnameinfo and getaddrinfo.

Anyway, I will do more investigating and raise a discussion on net-dev.

-- Regards,

Shi Jun Zhang

More information about the jdk7u-dev mailing list