Request for approval: 7181353: Update error message to distinguish native OOM and java OOM in net (original) (raw)

Seán Coffey sean.coffey at oracle.com
Tue Sep 25 05:17:12 PDT 2012

Approved for jdk7u-dev then. I'll update bug records when I see the push.

Please don't log a new CR, I think it is not necessary. Thanks. If you ever want to update the message to be more precise, just mail me and I'll get a bug record created.

regards, Sean.

On 25/09/2012 08:00, Sean Chou wrote:

Hi Seán,

I updated the webrev, now the message is the same as in jdk8. New webrev: http://cr.openjdk.java.net/~zhouyx/7181353/jdk7u/webrev.01/ Please don't log a new CR, I think it is not necessary. Thanks. On Mon, Sep 24, 2012 at 6:59 PM, Seán Coffey <sean.coffey at oracle.com> wrote: Sean,

tweaking the error messages makes more sense and helps diagnostics. Could I ask you to port the original 7181353 changeset from jdk8 to 7u ? I can log a new CR where you could then update jdk8 & 7u with the modified strings if you wish. I think it makes sense to keep 7u and 8 consistent in this area. What do you think ? Regards, Sean.

On 24/09/12 08:16, Sean Chou wrote: Hello, This is request for approval to push the fix of 7181353 to jdk7u, please take a look. Link to the bug: http://bugs.sun.com/bugdatabase/viewbug.do?bugid=7181353 Changeset in jdk8: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/15a6b0bceb1e Webrev for jdk7u: http://cr.openjdk.java.net/~zhouyx/7181353/jdk7u/webrev/ There are several differences between changeset in jdk8 and webrev for jdk7, however, all modifications are about adding a little more information to error message. Review thread: http://mail.openjdk.java.net/pipermail/net-dev/2012-July/004516.html

More information about the jdk7u-dev mailing list