[7u-dev] Request for approval for JDK-7175464 (original) (raw)

[7u-dev] Request for approval for JDK-7175464 - entrySetView field is never updated in NavigableSubMap

Doug Lea dl at cs.oswego.edu
Fri Feb 8 11:43:33 PST 2013


On 02/08/13 14:33, Mike Duigou wrote:

Hello all;

I would like to backport this change from Java 8. It has been baking in JDK8 for about two months with no problems.

I think it may have problems. As I mentioned in a post a few months ago, it seems to be responsible for breakage in a TCK/JCK test; One derived from a jsr166 tck test at http://gee.cs.oswego.edu/cgi-bin/viewcvs.cgi/jsr166/src/test/tck/TreeSubSetTest.java?view=log

You need the file for context, but it looks like:

 public void testDescendingSerialization() throws Exception {
     NavigableSet x = dset5();
     NavigableSet y = serialClone(x);

     assertTrue(x != y);
     assertEquals(x.size(), y.size());
     assertEquals(x.toString(), y.toString());
     assertEquals(x, y);
     assertEquals(y, x);
     while (!x.isEmpty()) {
         assertFalse(y.isEmpty());
         assertEquals(x.pollFirst(), y.pollFirst());
     }
     assertTrue(y.isEmpty());
 }

http://bugs.sun.com/bugdatabase/viewbug.do?bugid=7175464

http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/bf6ceb6b8f80 The change was previously reviewed by Alan Bateman, Paul Sandoz and David Holmes before going in to Java 8. Mike



More information about the jdk7u-dev mailing list