[7u] Request for approve for CR 8015976 OpenJDK part of bug JDK-8015812 [TEST_BUG] Tests have conflicting test descriptions (original) (raw)
Konstantin Shefov konstantin.shefov at oracle.com
Thu Jun 6 08:02:20 PDT 2013
- Previous message: [7u] Request for approve for CR 8015976 OpenJDK part of bug JDK-8015812 [TEST_BUG] Tests have conflicting test descriptions
- Next message: [7u] Request for approve for CR 8015976 OpenJDK part of bug JDK-8015812 [TEST_BUG] Tests have conflicting test descriptions
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
There are a lot of test pairs (.java + .html) in JDK repo where both files contain jtreg tags, although only one file contains @test tag. I think it is not necessary to remove other tags, because they show that the given file is a part of the given test for @bug and its author, etc.
Konstantin On 06-Jun-13 18:18, Yuri Nesterenko wrote:
I didn't look into sources of jtreg stuff! Basically, I understand that our test is either one or several files, and only one of them should have @test tag inside. Simplest example, .java and .html pair for running in appletviewer: @test should be in .html only.
Now, I always thought that a line with 'test' (without @) was harmless and mean nothing, and so might be removed. If not, well, I don't like annotation keywords without prefix:-) -yan On 06/06/2013 05:30 PM, Konstantin Shefov wrote: Yuri, what do you think about it? -Konstantin
On 06-Jun-13 17:29, Alan Bateman wrote: On 06/06/2013 14:26, Konstantin Shefov wrote: No, it is not necessary
Maybe I'm missing something but when you remove the @test then aren't the rest of the tags orphaned? -Alan.
- Previous message: [7u] Request for approve for CR 8015976 OpenJDK part of bug JDK-8015812 [TEST_BUG] Tests have conflicting test descriptions
- Next message: [7u] Request for approve for CR 8015976 OpenJDK part of bug JDK-8015812 [TEST_BUG] Tests have conflicting test descriptions
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]