AW: [7u60] Request for approval : 8022698 [TEST] javax/script/GetInterfaceTest.java fails since 7u45 b04 when run with jtreg -agentvm option (original) (raw)

A. Sundararajan sundararajan.athijegannathan at oracle.com
Thu Jan 2 05:51:03 PST 2014

Hi Sean,

This fix looks good to me.

Thanks -Sundar

On Thursday 02 January 2014 07:19 PM, Seán Coffey wrote:

Sundar,

can you review this small test change for benefit of public code review ? thanks! Sean. On 25/12/13 22:23, Dalibor Topic wrote: Thanks, Sean, this looks fine to me - approved for jdk7u-dev.

cheers, dalibor topic ----- Ursprüngliche Mail ----- Von: sean.coffey at oracle.com An: sundararajan.athijegannathan at oracle.com, jdk7u-dev at openjdk.java.net Gesendet: Mittwoch, 25. Dezember 2013 11:07:00 GMT +01:00 Amsterdam/Berlin/Bern/Rom/Stockholm/Wien Betreff: [7u60] Request for approval : 8022698 [TEST] javax/script/GetInterfaceTest.java fails since 7u45 b04 when run with jtreg -agentvm option This is a testcase fix. 7u45 changes put restrictions in the RhinoScript implementation. This testcase has been failing in jtreg agent mode since then. Fix is trivial and involves making the interface public. Patch pasted below. Already fixed in 7u51 but I'd like to sync to 7u60 now to help testing metrics there. Sundararajan Athijegannathan has reviewed the fix but I'm cc'ing him here so we can have public record. Sundar - please review if possible. bug link : https://bugs.openjdk.java.net/browse/JDK-8022698 regards, Sean. 8022698: javax/script/GetInterfaceTest.java fails since 7u45 b04 with -agentvm option Reviewed-by: sundar --- a/test/javax/script/GetInterfaceTest.java Tue Nov 19 08:37:13 2013 -0800 +++ b/test/javax/script/GetInterfaceTest.java Thu Nov 21 13:39:01 2013 +0000 @@ -67,11 +67,11 @@ public class GetInterfaceTest { foo2.bar2(); } - interface Foo { + public interface Foo { public void bar(); } - interface Foo2 extends Foo { + public interface Foo2 extends Foo { public void bar2(); } }

More information about the jdk7u-dev mailing list