Fwd: Re: Request for Review of 7116890 (Warning Cleanup java.io) (original) (raw)
Sebastian Sickelmann sebastian.sickelmann at gmx.de
Thu Dec 1 11:20:35 PST 2011
- Previous message: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011
- Next message: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Am 01.12.2011 18:15, schrieb Alan Bateman:
On 01/12/2011 16:27, Sebastian Sickelmann wrote:
: Thanks for the good feedback.
I splitted my change to the trivial part and will start discussion of FilePermission change on core-libs-dev after the cleanup event. I created a new webrev with the suggested changes here[2] [2] http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/WarningCleanupJavaio/CR71168900/index.html -- Sebastian In ExpiringCache L67-68 it looks like you are missing the type parameters. Also I assume we can change L119-120 to be for(String key: keySet) { ... } (I realize this is not strictly a warnings change). Otherwise I think it's okay. -Alan. Thanks Alan, L67-68 was a backporting (from a more complex solution to a small warning cleanup) issue. I missed the type parameters here. I changed L119-120 also.
New webrev is here: http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/Warning_Cleanup_Java_io/CR7116890_1/index.html
-- Sebastian
- Previous message: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011
- Next message: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]