Review Request for 7116993 (warning cleanup java.applet) (original) (raw)

Danesh Dadachanji ddadacha at redhat.com
Thu Dec 1 13:39:35 PST 2011

Hi,

On 01/12/11 04:14 PM, Brandon Passanisi wrote:

I'll withdraw this review request as I was notified by Xiomara that someone else has been working on java.applet. I had sent an e-mail to the alias yesterday about taking on java.applet though. Luckily, there aren't many warnings in java.applet.

Once again, I apologize for the confusion. I assumed sending a private email would be fine with the info being on the wiki.

In any case, the changes I made are identical to yours so that's promising! One thing that I noticed is that resize(int, int) calls a deprecated Component.size() and Component.resize(int, int). Changing the calls of size and super.resize to getSize and super.setSize respectively might be better. However, that changes functionality. Comments on this?

As Brandon requested, I'll reuse the bug ID (7116993). My webrev is here:

http://icedtea.classpath.org/~ddadacha/warnings-cleanup-java-applet/

Regards,

Danesh

More information about the jdk8-dev mailing list