Tests (Was Warnings Cleanup in java.util. (more from hack day)) (original) (raw)

Mario Torre neugens.limasoftware at gmail.com
Sat Dec 3 03:34:55 PST 2011

Il giorno 03/dic/2011, alle ore 12:27, Martijn Verburg ha scritto:

Hi all,

So the recent warnings clean up exercise got me thinking about the approach we took and how we could make it safer by applying/running tests in some of these areas. I'm very new to the OpenJDK, but I figure there must be a suite of tests (for the TCK if nothing else). Is that the set of tests that are typically run? Or is there another test suite that can be run/added to? For example I feel that could/should have written a unit test for the write method in the Manifest class that I had my recent brain melt in :-) Thoughts? Cheers, Martijn

Of course, you can write jtreg tests :)

The warning fixes were low risk changes (this is why everyone was very picky about changing anything but the warnings) and in many areas the JDK is well tested, so there was no real reason to write tests for most of it, but this is not generally true of course. So, to answer your question, yes, you can write a jtreg test and propose it as companion to your code changes, this is never a bad idea anyway, just double check that the test you're going to write doesn't exist already (so you add more, rather than duplicating it).

Cheers, Mario

pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF Fingerprint: BA39 9666 94EC 8B73 27FA FC7C 4086 63E3 80F2 40CF

http://www.ladybug-studio.com

IcedRobot: www.icedrobot.org Proud GNU Classpath developer: http://www.classpath.org/ Read About us at: http://planet.classpath.org OpenJDK: http://openjdk.java.net/projects/caciocavallo/

Please, support open standards: http://endsoftpatents.org/

More information about the jdk8-dev mailing list