RFR 8011805: Update sun.tools.java class file reading/writing support to include the new constant pool entries (including invokedynamic) (original) (raw)
Mike Duigou mike.duigou at oracle.com
Wed Apr 10 21:32:31 PDT 2013
- Previous message: RFR 8011805: Update sun.tools.java class file reading/writing support to include the new constant pool entries (including invokedynamic)
- Next message: RFR 8011805: Update sun.tools.java class file reading/writing support to include the new constant pool entries (including invokedynamic)
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
License on test is the wrong one. Tests don't have classpath exemption.
The initial block comment with @test doesn't have the normal leading * on each line.
The commented out part mentioning testWrite should just be removed along with unreferenced code.
Looks otherwise fine to me.
Mike
On Apr 10 2013, at 21:24 , Robert Field wrote:
Currently blocking lambda library pushes. Internal class reader used by rmic does not support new constant pool constant types:
CONSTANTMETHODHANDLE = 15; CONSTANTMETHODTYPE = 16; CONSTANTINVOKEDYNAMIC = 18;
Please review the fix for CR: http://bugs.sun.com/bugdatabase/viewbug.do?bugid=8011805 Webrev: http://cr.openjdk.java.net/~rfield/8011805/
- Previous message: RFR 8011805: Update sun.tools.java class file reading/writing support to include the new constant pool entries (including invokedynamic)
- Next message: RFR 8011805: Update sun.tools.java class file reading/writing support to include the new constant pool entries (including invokedynamic)
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]