RFR: 8004518 & 8010122 : Default methods on Map (original) (raw)

Mike Duigou mike.duigou at oracle.com
Tue Apr 16 11:04:45 PDT 2013

On Apr 15 2013, at 16:13 , Ulf Zibis wrote:

Am 15.04.2013 23:06, schrieb Mike Duigou:

That's because I'm not the only author. I get to fix it though, the glamourous life of a JDK janitor. :-) ;-)

HashTable line 917, 938, 984 etc. HashMap line 588 etc. Collections line 1402 etc. Should be more consistent now. I'm not willing to attempt correct this non-problem more broadly. HashTable line 972, 992, 1011, 1035, 1064, 1099, etc.

These don't seem to line up with anything in either rev 5 or 6 of Hashtable source (or HashMap).

Collections: lines 1442... + 3900... , indentation for follow up line should be 8 There are still lines 976, 1062 Of which file? According to http://cr.openjdk.java.net/~mduigou/JDK-8010122/5/webrev/src/share/classes/java/util/Collections.java.html neither of those lines seems applicable. Oops I'm sorry, I meant lines 976, 1062 of Map.

Corrected.

In Collections I've found additional inconsistent indentations, lines 2836, 2837, 2848, 2853, 2897

Corrected.

Old code: 262, 270, 292, 1248, 1304, 1528, 1580, 1611, 1784, 1873, 1995, 2036, 2092, 2304, 2414, 2460, 2694, 2760, 2770, 2819, 3032, 3071, 3118, 3155, 3164, 3214, 3273, 3318, 3322, 3358, 3397, 3446, 3559, 3633, 3756, 3790, 3809, 3832, 3867, 3965, 4014, 4070, 4109, 4133, 4301, 4381, 4413, 4445.

I am unwilling to change most of these.

Thank you for your careful review. You definitely have sharper eyes than most for this kind of problem.

Mike

More information about the lambda-dev mailing list