RFR: 8001647: In-place methods on Collection/List (original) (raw)

Akhil Arora akhil.arora at oracle.com
Sun Apr 21 10:46:40 PDT 2013

On 04/21/2013 04:33 AM, Alan Bateman wrote:

On 20/04/2013 02:39, Akhil Arora wrote:

On 04/19/2013 04:15 AM, Alan Bateman wrote:

On 18/04/2013 19:49, Akhil Arora wrote:

Looks like the stars are aligning on getting on this into TL... the refreshed webrev is -

http://cr.openjdk.java.net/~akhil/8001647.8/webrev/ A minor comment on Collection.removeIf is "that satisifies the given predicate" might be better than "which matches the provided predicate". Also for completeness, you could say "RuntimeExceptions and Errors thrown by the predicate are propagated ...". fixed both Thanks, I see the update to Collection.removeIf. I don't see the update to List.replaceAll so that could be changed to be consistent before you push this.

Updated List.replaceAll. I noticed a few other inconsistencies, corrected them in 8001647.9 -

http://cr.openjdk.java.net/~akhil/8001647.9/webrev/

the two changes are -

http://hg.openjdk.java.net/lambda/lambda/jdk/rev/f51da04f3899

and

http://hg.openjdk.java.net/lambda/lambda/jdk/rev/d907dff00ace

Thanks

More information about the lambda-dev mailing list