webrevs.2 for macosx changes to jdk7u-osx (original) (raw)

Michael McMahon michael.x.mcmahon at oracle.com
Tue Nov 29 06:34:23 PST 2011

Artem,

Thanks for looking at this!

Actually I just realised that your comments were on the changes relative to macosx-port. I only included that webrev for reference, in order to identify if there were mac related changes that I might have missed. So, that is why there are a number of files with no changes.

In any case, many of your comments are still useful. I have removed the extraneous definitions from the makefiles. I also made the change to UIManager and java_props_md.c

The change from "malloc.h" to stdlib.h is a simplification because stdlib is actually the correct include for malloc(), so it works the same on all platforms.

awt_LoadLibrary.c is a complicated change, and I'd certainly appreciate your view on the webrev (relative to jdk7-osx) and indeed the other changes relative to jdk7-osx as well.

Thanks Michael.

More information about the macosx-port-dev mailing list