[7u6] Review request for 7131021: [macosx] Consider using system properties to pass arguments from the launcher to AWT/SplashScreen (original) (raw)
Anthony Petrov anthony.petrov at oracle.com
Tue Apr 10 10:23:12 PDT 2012
- Previous message: [8] Request for review: 7124272: [macosx] VK_DELETE does produce an extraneous character in a TextArea or TextField
- Next message: [7u6] Review request for 7131021: [macosx] Consider using system properties to pass arguments from the launcher to AWT/SplashScreen
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hello,
Please review a fix for http://bugs.sun.com/view_bug.do?bug_id=7131021 at:
http://cr.openjdk.java.net/~anthony/7u6-2-keepEnvVars-7131021.0/
The comments added to java_md_macosx.c have been approved by CCC already. This is mainly a review for the newly added test that checks for the environment variables that can be set by the launcher on the Mac.
A short background to avoid any confusion regarding the synopsis of the bug. We've discussed the issue thoroughly and come to a conclusion that we want to preserve the existing behavior, i.e. use the environment variables to pass some information from the launcher to AWT. With this fix we add comments to the source code to make sure maintainers of the code are aware of compatibility issues related to the variables, should they need to modify this code. Also, we're adding an automatic regression test that verifies that the launcher correctly sets these variables.
-- best regards, Anthony
- Previous message: [8] Request for review: 7124272: [macosx] VK_DELETE does produce an extraneous character in a TextArea or TextField
- Next message: [7u6] Review request for 7131021: [macosx] Consider using system properties to pass arguments from the launcher to AWT/SplashScreen
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]