[7u6] request for review: 7124328: [macosx] javax.swing.JDesktopPane.getAllFramesInLayer returns unexpected value (original) (raw)

Anthony Petrov anthony.petrov at oracle.com
Wed Apr 11 05:26:18 PDT 2012

Hi Alex,

It seems like the new private getAllFrames(Contianer) method may be declared as static. Also I suggest to insert spaces between "if"s and "("s at lines 275, 277, and 282. Otherwise the changes look good.

BTW, do we have any regression tests for this method? Do they pass? What about the performance regression caused by iterating over the inner containers?

-- best regards, Anthony

On 4/10/2012 9:25 PM, Alexander Potochkin wrote:

Hello

Please review the following fix: http://cr.openjdk.java.net/~alexp/7124328/webrev.00/ for this bug: http://bugs.sun.com/bugdatabase/viewbug.do?bugid=7124328 the spec for the method javax.swing.JDesktopPane.getAllFrames() says * Returns all JInternalFrames currently displayed in the * desktop. Returns iconified frames as well as expanded frames. but the AquaLookAndFeel on MacOS uses a special container for the minimized internal frames and that's why the current implementation doesn't see them the proposed fix recursively looks for the internal frames among the JDesktopPane's children the test can be found here: http://java.net/jira/browse/MACOSXPORT-557 Thanks alexp

More information about the macosx-port-dev mailing list