[7u6] request for review: 7124328: [macosx] javax.swing.JDesktopPane.getAllFramesInLayer returns unexpected value (original) (raw)

Alexander Potochkin Alexander.Potochkin at oracle.com
Tue Apr 24 07:40:23 PDT 2012

• Previous message: [7u6] request for review: 7124328: [macosx] javax.swing.JDesktopPane.getAllFramesInLayer returns unexpected value
• Next message: [7u6] Review request for 7131021: [macosx] Consider using system properties to pass arguments from the launcher to AWT/SplashScreen
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hello Artem

add/remove are of the same kind :) Anyway, I'm leaving it up to you. The fix looks fine.

Thanks!

alexp

Thanks, Artem

so I guess it is fine to use ArrayList here

Thanks alexp

Thanks, Artem On 4/10/2012 9:25 PM, Alexander Potochkin wrote: Hello Please review the following fix: http://cr.openjdk.java.net/~alexp/7124328/webrev.00/ for this bug: http://bugs.sun.com/bugdatabase/viewbug.do?bugid=7124328 the spec for the method javax.swing.JDesktopPane.getAllFrames() says * Returns all JInternalFrames currently displayed in the * desktop. Returns iconified frames as well as expanded frames. but the AquaLookAndFeel on MacOS uses a special container for the minimized internal frames and that's why the current implementation doesn't see them the proposed fix recursively looks for the internal frames among the JDesktopPane's children the test can be found here: http://java.net/jira/browse/MACOSXPORT-557 Thanks alexp

• Previous message: [7u6] request for review: 7124328: [macosx] javax.swing.JDesktopPane.getAllFramesInLayer returns unexpected value
• Next message: [7u6] Review request for 7131021: [macosx] Consider using system properties to pass arguments from the launcher to AWT/SplashScreen
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the macosx-port-dev mailing list