Code Review Request: 7141465:[macosx] com/sun/jdi/PrivateTransportTest.sh fails on Mac OS X (original) (raw)
Michael McMahon michael.x.mcmahon at oracle.com
Wed Feb 1 01:19:24 PST 2012
- Previous message: hg: jdk7u/jdk7u-osx/jdk: 7129825: [macosx] Native activation is not changed when focusing other frame's owned window
- Next message: hg: jdk7u/jdk7u-osx/jdk: 2 new changesets
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Looks fine. We can re-factor that code some time later. But, for today that will do fine.
Thanks Michael
On 31/01/12 21:42, Kurchi Hazra wrote:
Right, I did not need to change jreloc at all. Updated webrev:
http://cr.openjdk.java.net/~khazra/7141465/webrev.02
- Kurchi
On 1/31/2012 1:22 PM, Scott Kovatch wrote: On Jan 31, 2012, at 12:56 PM, Alan Bateman wrote:
On 31/01/2012 20:40, Kurchi Hazra wrote: Hi,
This fix updates com/sun/jdi/PrivateTransportTest.sh file to run on Mac OS (Darwin).
Bug :http://bugs.sun.com/bugdatabase/viewbug.do?bugid=7141465 Webrev :http://cr.openjdk.java.net/~khazra/7141465/webrev.00/ I'mnot sure that ${TESTJAVA}/j2sdk-image/1.7.0.jdk/Contents/Home/jre is right, shouldn't TESTJAVA point to the Home directory? The rest of it looks okay to me. This will break, eventually. We need to adjust the build so the bundled JDK is built to j2sdk-bundles, and j2sdk-image remains stable throughout the build. It will also break if the name of the bundle changes, which is also planned. See 7133768 and 7128699, respectively. -- Scott K.
- Previous message: hg: jdk7u/jdk7u-osx/jdk: 7129825: [macosx] Native activation is not changed when focusing other frame's owned window
- Next message: hg: jdk7u/jdk7u-osx/jdk: 2 new changesets
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]