Request for review: 7124543 [macosx] Horizontal scrolling doesn't work (original) (raw)
Anthony Petrov anthony.petrov at oracle.com
Tue Feb 7 11:45:21 PST 2012
- Previous message: Request for review: 7124543 [macosx] Horizontal scrolling doesn't work
- Next message: Request for review: 7124543 [macosx] Horizontal scrolling doesn't work
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi Sergey,
On 2/7/2012 10:31 PM, Sergey Bylokhov wrote:
- Now we take into account native horizontal scroll event and invert the SHIFT modifier state.
It looks like with your fix you actually add the SHIFT modifier almost unconditionally at line 102 in CPlatformResponder.java, rather than invert it. It will even be added for regular vertical scrolling events. Is this correct?
Also, if an argument list of a method spans several lines we usually tend to insert a line break before the opening '{' for better readability. It would be great to follow this formatting practice with this fix as well. (No need to reformat everything, just those methods which prototypes you've already modified with your fix.)
-- best regards, Anthony
- scrollAmount was changed from 3 to 1 to be closer to apple jdk 6. - small cleanup.
Bug: http://monaco.sfbay.sun.com/detail.jsf?cr=7124543 Webrev can be found at: http://cr.openjdk.java.net/~serb/7124543/webrev.00/
- Previous message: Request for review: 7124543 [macosx] Horizontal scrolling doesn't work
- Next message: Request for review: 7124543 [macosx] Horizontal scrolling doesn't work
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]