RFR: 7113349 JDK8 port to macosx (original) (raw)

Anthony Petrov anthony.petrov at oracle.com
Thu Feb 23 05:13:50 PST 2012

One more thing: src/solaris/classes/sun/awt/X11/XWM.java contains a patch from bsd-port [1] which is unrelated to Mac OS or 7u4-specific changes. I think that this change might have been added when porting from macosx-port repo to the 7u-dev one. On the one hand, the change itself is somewhat harmless, on the other hand we don't have a corresponding CR for this change...

I think there might be some other pieces from the bsd port that don't actually belong to the JDK mainline.

[1] http://hg.openjdk.java.net/bsd-port/bsd-port/jdk/rev/aa821b5df19d

-- best regards, Anthony

On 2/23/2012 4:44 PM, Michael McMahon wrote:

Anthony,

Yes, sorry about that, when checking the webrev before sending it, I concentrated on the modified files, rather than the new ones. So, any new files in the webrev that are not clearly macos related need to be treated with some suspicion. I'll probably be generating a new webrev soon with changes to jprt configuration and the langtools changes mentioned by Jim, but let me know anything else you notice in the meantime. Thanks, Michael On 23/02/12 12:27, Anthony Petrov wrote: Hi Michael,

I've noticed your webrev adds files belonging to the legacy MToolkit (e.g. src/solaris/native/sun/awt/awt*). These files have been removed explicitly from JDK 8 with a fix for 6996291. I think we should examine the list of hg add'ed files carefully to see if they were really added in 7u-dev or not. -- best regards, Anthony On 2/23/2012 1:50 AM, Michael McMahon wrote: This is the webrev for the Mac OS changes for JDK8. It is pretty much a straight merge of the current jdk7u-dev changes. It builds and passes most JCK and regression tests with only a small number of failures.

http://cr.openjdk.java.net/~michaelm/7113349/jdk8/webrev.1/ There are three separate webrevs at the link above for the three separate repositories affected (the top-level, corba and jdk). Obviously most of the changes are in the jdk webrev. Comments welcome! Thanks, Michael.

More information about the macosx-port-dev mailing list