Review request for 7128699: Make jdk and jre installation directories consistent on Mac OS X (original) (raw)

Scott Kovatch scott.kovatch at oracle.com
Thu Feb 23 15:45:55 PST 2012

On Feb 23, 2012, at 1:54 PM, Mike Swingler wrote:

On Feb 21, 2012, at 10:18 PM, Scott Kovatch wrote:

Hello,

Please review the following fix: http://cr.openjdk.java.net/~skovatch/7128699/webrev.00/ The bug description is here: http://bugs.sun.com/bugdatabase/viewbug.do?bugid=7128699 The name of the created JDK and JRE bundle isn't including the JDKUPDATEVERSION. Use JDKVERSION instead of THISJDKVERSION so it gets picked up. Also, prefix the bundle with 'jdk' or 'ire' as needed to match other platforms. We maintain the bundle extension so it is recognized as a bundle on Mac OS X, but if filename extensions are turned off in the finder you can't tell a JDK from a JRE. If this hasn't been reviewed already by someone at Oracle, this looks like a good change, and will facilitate the ability to install these bundles side-by-side. Is THISJDKVERSION used anywhere else? Could it be removed at the definition point?

Yes, it's used in jdk/make/common/Release.gmk to generate the 'release' file at the top of the distribution tree. It looks like it would be a bad thing to get rid of it.

This will have to go in as a critical 7u4 fix at this point, so I'll start that process.

-- Scott

More information about the macosx-port-dev mailing list