[7u4] Review request for 7147435: closed/java/awt/Toolkit/Headless/WrappedToolkitTest/WrappedToolkitTest.sh failed since 7u4b11 (original) (raw)
Alexander Zuev alexander.zuev at oracle.com
Tue Feb 28 04:36:36 PST 2012
- Previous message: [7u4] Review request for 7147435: closed/java/awt/Toolkit/Headless/WrappedToolkitTest/WrappedToolkitTest.sh failed since 7u4b11
- Next message: Request for phase 2 approval for CR 7124262 - [macosx] Drag events go to a wrong child.
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Anthony,
fix looks fine to me.
With best regards, Alex
On 2/27/12 17:30, Anthony Petrov wrote:
Hello,
Please review a fix for http://bugs.sun.com/bugdatabase/viewbug.do?bugid=7147435 at: http://cr.openjdk.java.net/~anthony/7u4-2-headlessTestFailed-7147435.0/ This bug is a regression of 7124511 fixed for the JDK Mac Port [1]. With that fix the code setting the awt.toolkit and java.awt.graphicsenv system properties has been removed from JNIOnLoad() of libawt.so. Actually, the test WrappedToolkitTest.sh relies on the ability to override the default toolkit by means of setting the AWTTOOLKIT environment variable, and because of the removal the test has failed. With the fix for 7147435 I'm restoring the removed parts. In order to not break the fix for 7124511, I'm setting the system properties only if the XToolkit has been requested explicitly. [1] http://cr.openjdk.java.net/~anthony/x-5-forceHeadless.0/ -- best regards, Anthony
- Previous message: [7u4] Review request for 7147435: closed/java/awt/Toolkit/Headless/WrappedToolkitTest/WrappedToolkitTest.sh failed since 7u4b11
- Next message: Request for phase 2 approval for CR 7124262 - [macosx] Drag events go to a wrong child.
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]