[7u4] Request for review: 7124537 [macosx] Menu shortcuts for all menu items should be disabled if a menu itself is disabled (original) (raw)
Anthony Petrov anthony.petrov at oracle.com
Wed Feb 29 07:52:00 PST 2012
- Previous message: [7u4] Review request for 7145818: [macosx] dialogs not showing when JFrame is in full screen mode
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Oh, I see. Thanks for clarifying that. Looks fine then.
-- best regards, Anthony
On 2/29/2012 7:50 PM, Sergey Bylokhov wrote:
29.02.2012 19:06, Anthony Petrov wrote:
Hi Sergey,
I'm not an expert in the Menu code, but generally the fix looks good. By the way, LWCToolkit.java doesn't contain any changes. Should it? There is a changes in formatting http://cr.openjdk.java.net/~serb/7124537/webrev.00/jdk.patch -- best regards, Anthony On 2/29/2012 4:50 PM, Sergey Bylokhov wrote: Does anybody has a chance to review it? Thanks.
22.02.2012 22:08, Sergey Bylokhov wrote: Hi Everyone, Change description: 1 CMenu.java: state of all elements for the current menu changes now. Before the fix, menu in menubar didn't change status. 2 CMenuItem.java: menu item can be enabled only if parent is enabled too. Native code execute only if status was changed. Fix was created on the java level instead of native. Please comment if you have an objections.
Bug: http://bugs.sun.com/bugdatabase/viewbug.do?bugid=7124537 Webrev can be found at: http://cr.openjdk.java.net/~serb/7124537/webrev.00/
- Previous message: [7u4] Review request for 7145818: [macosx] dialogs not showing when JFrame is in full screen mode
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]