RFR (S): 7125793: MAC: test_gamma should always work (original) (raw)

Daniel D. Daugherty daniel.daugherty at oracle.com
Mon Jan 9 15:37:24 PST 2012

On 1/7/12 9:38 AM, James Melvin wrote:

WEBREV: http://cr.openjdk.java.net/~jmelvin/7125793/webrev.01

make/bsd/Makefile No comments.

make/bsd/makefiles/buildtree.make No comments.

make/bsd/makefiles/defs.make Thanks for fixing this one for BSD platforms.

make/bsd/makefiles/launcher.make line 60: typo: 'inadvertenly' -> 'inadvertently'

 Sorry I missed this in my first review, but the addition
 of '-framework CoreFoundation' to LFLAGS_LAUNCHER is
 probably MacOS X specific. I think:

     ifeq ($(OS_VENDOR), Darwin)
     else
     endif

 will work in launcher.make also.

make/bsd/makefiles/vm.make No comments.

src/os/bsd/vm/os_bsd.cpp line 2544: typo: 'overriden' -> 'overridden' line 2588: typo: 'overriden' -> 'overridden'

 Looks like old code line 2576 depended on the 'hotspot'
 symlink to refer to either 'client' or 'server' or whatever
 JVM you wanted to run. I'm fairly certain that the 'hotspot'
 symlink was retired; I'm just not sure when.

src/os/posix/launcher/java_md.c No comments.

Dan

More information about the macosx-port-dev mailing list