Review request for MACOSX_PORT-784: Program freeze when Swing is used with -XstartOnFirstThread (original) (raw)
Artem Ananiev artem.ananiev at oracle.com
Wed Jan 11 05:49:38 PST 2012
- Previous message: Review request for MACOSX_PORT-784: Program freeze when Swing is used with -XstartOnFirstThread
- Next message: [7u4] Request for approval for CR 7124515 [macosx] Test fail like 6366126 (ArrayIndexOutOfBoundException pressing ENTER after removing items)
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Dmitry and I discussed this change offline, and I don't see any problems with the fix. However, it would be fine if anyone who is more familiar with OGL could also take a look.
Thanks,
Artem
On 1/11/2012 6:00 PM, Dmitry Cherepanov wrote:
Hello,
Please review a fix for http://java.net/jira/browse/MACOSXPORT-784 at http://cr.openjdk.java.net/~dcherepanov/7128597/webrev.0/ To avoid the deadlock, the fix includes: - the addition of +[NSThread isMainThread] to ensure that we don't call -performSelectorOnMainThread: when the current thread is the AppKit thread - also, the fix doesn't invoke the getCGLConfigInfo method on the queue flusher thread - after the fix, the getCGLConfigInfo method is executed on the current thread directly. Thanks, Dmitry
- Previous message: Review request for MACOSX_PORT-784: Program freeze when Swing is used with -XstartOnFirstThread
- Next message: [7u4] Request for approval for CR 7124515 [macosx] Test fail like 6366126 (ArrayIndexOutOfBoundException pressing ENTER after removing items)
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]