Review request for MACOSX_PORT-539: Need a java.awt.EmbeddedFrame subclass (original) (raw)
Dmitry Cherepanov dmitry.cherepanov at oracle.com
Wed Jan 11 07:06:27 PST 2012
- Previous message: Review request for MACOSX_PORT-539: Need a java.awt.EmbeddedFrame subclass
- Next message: Review request for 7124283: [macosx] Can't move focus out of a table with the keyboard
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Dmitry Cherepanov wrote:
2. Is there a reason to explicitly call addNotify() in CEF constructor? Will it be called automatically as a part of show()? Done. Here's the update webrev:
http://cr.openjdk.java.net/~dcherepanov/7124335/webrev.1/
5. What is the reason of exporting the getPeer() method in the PlatformWindow interface? It's done as a part of the changes in src/macosx/classes/sun/lwawt/macosx/CPlatformComponent.java The change removes explicit reference to the CPlatformWindow class (to make it working for CPlatformEmbeddedFrame) but it still needs to call platformWindow.getPeer() (see the setBounds method). It could probably be refactored into a more simplified code (to remove the getPeer method from the PlatformWindow interface). I'll refactor the code as a part of http://java.net/jira/browse/MACOSX_PORT-78 (still open issue as there's a number of limitation of the current JAWT implementation).
Thanks, Dmitry
- Previous message: Review request for MACOSX_PORT-539: Need a java.awt.EmbeddedFrame subclass
- Next message: Review request for 7124283: [macosx] Can't move focus out of a table with the keyboard
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]