Code review: 7126979 (props) JCK test java_lang/System/GetProperties.java failing [macosx] (original) (raw)

David Holmes david.holmes at oracle.com
Thu Jan 12 05:02:29 PST 2012

On 12/01/2012 10:49 PM, Michael McMahon wrote:

Thanks David. Just found it now (Alan noticed it too). Scott sent his webrev yesterday.

It looks like both solutions fix the problem. The difference is that Scott's re-initializes the properties from native code each time System.initProperties() is called. On the other platforms, we only call it once. So, do we want Macos to diverge slightly from the other platforms in this respect?

I haven't compared things in detail but If there is no need to diverge then I would not diverge.

David

My preference is to keep the platforms as similar as possible, minimising the changes with jdk7u ...

- Michael. On 12/01/12 11:52, David Holmes wrote: Michael,

There was a different patch for this posted earlier today where the props fields were all nulled out so they didn't reference the freed locations amy more. (I didn't keep the email) ??? David On 12/01/2012 9:22 PM, Michael McMahon wrote: Could I get the following change for jdk7u-osx reviewed please?

http://cr.openjdk.java.net/~michaelm/7126979/webrev.1/ The freeProps() call added by mac port can only be called once. Issue seen if System.setProperties(null) is called. GetJavaProperties() called a second time, which is supposed to return the statically populated information from first call. But some of it has been freed already. Fix is to remove the freeProps() code added in the original port changeset. The fix reverts the mac specific code to the original version. - Michael

More information about the macosx-port-dev mailing list