[7u4] Request for approval for CR 7124515 [macosx] Test fail like 6366126 (ArrayIndexOutOfBoundException pressing ENTER after removing items) (original) (raw)
Artem Ananiev artem.ananiev at oracle.com
Thu Jan 12 05:46:13 PST 2012
- Previous message: [7u4] Request for approval for CR 7124515 [macosx] Test fail like 6366126 (ArrayIndexOutOfBoundException pressing ENTER after removing items)
- Next message: Review request for 7124217: [macosx] key events are posted to the event queue twice
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi, Alexander,
the fix looks fine and corresponds to what we do on other platforms.
Thanks,
Artem
On 1/11/2012 6:08 PM, Alexander Scherbatiy wrote:
Hello,
Please review a fix for 7124515 [macosx] Test fail like 6366126 (ArrayIndexOutOfBoundException pressing ENTER after removing items) http://bugs.sun.com/bugdatabase/viewbug.do?bugid=7124515 webrev: http://cr.openjdk.java.net/~alexsch/7124515/webrev.00/ To avoid the IOBE the fix - Gets the selected value by the getSelectedValue() method and checks it to null instead of using the getSelectedIndex() index in the processKeyEvent() method - Checks the selected index bounds in the processMouseEvent() method The attached to the bug test is added to the repository. Mouse double click checking is added to the test.
Thanks, Alexandr.
- Previous message: [7u4] Request for approval for CR 7124515 [macosx] Test fail like 6366126 (ArrayIndexOutOfBoundException pressing ENTER after removing items)
- Next message: Review request for 7124217: [macosx] key events are posted to the event queue twice
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]