[7u4] Request for approval for 7124530 (original) (raw)
[7u4] Request for approval for 7124530 - What is background color of AWT component? (And foreground, for that matter)
Mike Swingler swingler at apple.com
Thu Jan 12 18:30:02 PST 2012
- Previous message: [7u4] Request for approval for 7124530 - What is background color of AWT component? (And foreground, for that matter)
- Next message: [7u4] Request for approval for 7124530 - What is background color of AWT component? (And foreground, for that matter)
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On Jan 12, 2012, at 4:24 AM, Sergey Bylokhov wrote:
Hello, This is a request to push the following changes to jdk7u-osx. The fix has been reviewed on macosx-port-dev mailing list by Alexander Potochkin.
Bug: http://bugs.sun.com/bugdatabase/viewbug.do?bugid=7124530 Webrev can be found at: http://cr.openjdk.java.net/~serb/7124530/webrev.00/ Technical review: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-January/002143.html
I don't understand this part:
--- old/src/macosx/native/sun/awt/CSystemColors.m 2011-12-28 19:02:19.913935900 +0400 +++ new/src/macosx/native/sun/awt/CSystemColors.m 2011-12-28 19:02:19.557915600 +0400 @@ -81,7 +81,8 @@ sColors[java_awt_SystemColor_INACTIVE_CAPTION] = [NSColor grayColor]; sColors[java_awt_SystemColor_INACTIVE_CAPTION_TEXT] = [NSColor grayColor]; sColors[java_awt_SystemColor_INACTIVE_CAPTION_BORDER] = [NSColor grayColor];
- sColors[java_awt_SystemColor_WINDOW] = [NSColor grayColor];
- const CGFloat color = (CGFloat)0xEE/(CGFloat)0xFF;
- sColors[java_awt_SystemColor_WINDOW] = [NSColor colorWithCalibratedRed:color green:color blue:color alpha:1.0f]; sColors[java_awt_SystemColor_WINDOW_BORDER] = [NSColor windowFrameColor]; sColors[java_awt_SystemColor_WINDOW_TEXT] = [NSColor windowFrameTextColor]; sColors[java_awt_SystemColor_MENU] = [NSColor controlBackgroundColor];
Why aren't you just using [NSColor windowBackgroundColor]?
Regards, Mike Swingler Apple Inc.
- Previous message: [7u4] Request for approval for 7124530 - What is background color of AWT component? (And foreground, for that matter)
- Next message: [7u4] Request for approval for 7124530 - What is background color of AWT component? (And foreground, for that matter)
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]