Code Review Request: 7127771: (macosx)test/java/net/Socket/TrafficClass.java fails on Mac OS X (original) (raw)
Michael McMahon michael.x.mcmahon at oracle.com
Mon Jan 16 02:43:55 PST 2012
- Previous message: Code Review Request: 7127771: (macosx)test/java/net/Socket/TrafficClass.java fails on Mac OS X
- Next message: Code Review Request: 7127771: (macosx)test/java/net/Socket/TrafficClass.java fails on Mac OS X
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Yes, looks fine to me too. I would just update the comment above this code to add Mac OS to the Solaris case.
Thanks Michael
On 13/01/12 21:02, Kurchi Hazra wrote:
How does this look: http://cr.openjdk.java.net/~khazra/7127771/webrev.01/
- Kurchi
On 1/13/2012 12:14 PM, Alan Bateman wrote:
Bug : http://bugs.sun.com/bugdatabase/viewbug.do?bugid=7127771 Webrev : http://cr.openjdk.java.net/~khazra/7127771/webrev.00/ What you have is fine although you could combine with the Solaris _code? Should the ALLBSDSOURCE XXX be removed while you are there? -Alan
- Previous message: Code Review Request: 7127771: (macosx)test/java/net/Socket/TrafficClass.java fails on Mac OS X
- Next message: Code Review Request: 7127771: (macosx)test/java/net/Socket/TrafficClass.java fails on Mac OS X
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]