Code Review Request: 7126993: JCK test api/java_util/jar/Jarfile jarFile0129 failing [macosx] (original) (raw)

Alan Bateman Alan.Bateman at oracle.com
Thu Jan 19 11🔞53 PST 2012

On 19/01/2012 18:56, Kurchi Hazra wrote:

Hi, JCK tests api/javautil/jar/Jarfile and api/javautil/zip/ZipFile were both failing on Mac because the OPENDELETE flag sets the JVMODELETE flag in native code, and the value of JVMODELETE was changed from 0x10000 to0x10000000 for Mac OS. The JVMODELETE flag is only used in src/share/native/java/util/zip/ZipFile.c and hence this change should be safe.

Bug : http://bugs.sun.com/bugdatabase/viewbug.do?bugid=7126993 Webrev : http://cr.openjdk.java.net/~khazra/7126993/webrev.00/ At some point we need to change the zip and other code so that it's not using the JVM_ functions (not needed anymore). I checked os_bsd.cpp and O_DELETE is defined as 0x10000 so this is the value that JVM_O_DELETE needs to have in jvm_md.d. I don't know why it was changed to 0x10000000 but it must have had a corresponding change in HotSpot at one point.

-Alan.

More information about the macosx-port-dev mailing list