Code Review Request: 7126993: JCK test api/java_util/jar/Jarfile jarFile0129 failing [macosx] (original) (raw)

Paul Hohensee paul.hohensee at oracle.com
Thu Jan 19 12:39:33 PST 2012

Actually, no, I don't have it. os_bsd.cpp is used in the macosx hotspot build. There's no separate osx code. So it should be changed in os_bsd.cpp too, right?

Paul

On 1/19/12 3:38 PM, Paul Hohensee wrote:

Ok, got it.

paul On 1/19/12 3:29 PM, Kurchi Hazra wrote:

On 1/19/2012 12:25 PM, Paul Hohensee wrote: I think the JVM names were intended to be used in platform-independent code. For "change required for the time being", are you referring to a change to osbsd.cpp? I meant jvmmd.h needs JVMODELETE to be reset to 0x10000 as pointed out in the webrev. osbsd.cpp already has ODELETE defined as 0x10000 and does not need any change I guess. - Kurchi

Paul On 1/19/12 3:17 PM, Kurchi Hazra wrote: I see that ODELETE is 0x10000 in osbsd.cpp in 7u4osx too. So basically, the only change required for the time being is the one in the webrev below. This maybe a stupid question, but if ODELETE is already defined, why do we have to use a separate JVMODELETE macro? Why can't we just use ODELETE in ZipFile.c? If the reason is consistency, that is to have all flags used in open() defined at one place in jvmmd.h, then why can't we just use a dummy macro such as ODEL and define it in jvmmd.h as ODELETE?

- Kurchi

On 1/19/2012 12:02 PM, Paul Hohensee wrote: If this change needs to be make, we should make the same change in osbsd.cpp. The original value of ODELETE in osbsd.cpp was 0x10000 and hasn't been changed since. Paul On 1/19/12 2:18 PM, Alan Bateman wrote: On 19/01/2012 18:56, Kurchi Hazra wrote: Hi, JCK tests api/javautil/jar/Jarfile and api/javautil/zip/ZipFile were both failing on Mac because the OPENDELETE flag sets the JVMODELETE flag in native code, and the value of JVMODELETE was changed from 0x10000 to0x10000000 for Mac OS. The JVMODELETE flag is only used in src/share/native/java/util/zip/ZipFile.c and hence this change should be safe.

Bug : http://bugs.sun.com/bugdatabase/viewbug.do?bugid=7126993 Webrev : http://cr.openjdk.java.net/~khazra/7126993/webrev.00/ At some point we need to change the zip and other code so that it's not using the JVM functions (not needed anymore). I checked osbsd.cpp and ODELETE is defined as 0x10000 so this is the value that JVMODELETE needs to have in jvmmd.d. I don't know why it was changed to 0x10000000 but it must have had a corresponding change in HotSpot at one point. -Alan.

More information about the macosx-port-dev mailing list