[7u4-osx] Please review: 7124089: launcher refactoring v1.0 (original) (raw)

Kumar Srinivasan kumar.x.srinivasan at oracle.COM
Fri Jan 20 08:24:12 PST 2012

Hi All,

Based on all the comments from Anthony, Joe and David, here is the modified version:

Highlights:

  1. re-factored code in solaris directory to be shared with macosx, reducing duplication across the *nixes.

  2. adjusted the makefilesto allow the above

  3. eliminated all conditionals from the shared java.c

  4. added a new launcher regression test for the macosx specific -X options

For those who have already reviewed the 0th version, here is an incremental webrev to make it easier reviewing the differences. http://cr.openjdk.java.net/~ksrini/7124089/webrev.1/webrev.delta/index.html

Here is the complete webrev: http://cr.openjdk.java.net/~ksrini/7124089/webrev.1/index.html

Thanks Kumar

More information about the macosx-port-dev mailing list