Review request for 7129825 - [macosx] Native activation is not changed when focusing other frame's owned window (original) (raw)
Dmitry Cherepanov dmitry.cherepanov at oracle.com
Tue Jan 31 02:23:19 PST 2012
- Previous message: Review request for 7129825 - [macosx] Native activation is not changed when focusing other frame's owned window
- Next message: [7u4-osx] Request approval for: 7124089: launcher refactoring
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Anton V. Tarasov wrote:
On 30.01.2012 16:06, Dmitry Cherepanov wrote:
Hi Anton,
The fix looks fine to me. Just one comment - the fix introduces new isActive method in the PlatformWindow interface (and removes parameters from requestWindowFocus). Could you please add some implementation into the CPlatformEmbeddedFrame class (simply returning true should be fine) as the class implements the PlatformWindow interface. Sure, I missed it. Here's the updated version: http://cr.openjdk.java.net/~ant/7129825/webrev.1/ Looks fine to me.
Thanks, Dmitry
- Previous message: Review request for 7129825 - [macosx] Native activation is not changed when focusing other frame's owned window
- Next message: [7u4-osx] Request approval for: 7124089: launcher refactoring
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]