Code Review: 6223635 Code hangs at connect call even when Timeout is specified when using a socks proxy (original) (raw)
Christopher Hegarty -Sun Microsystems Ireland Christopher.Hegarty at Sun.COM
Wed Mar 3 05:07:22 PST 2010
- Previous message: hg: jdk7/tl/langtools: 6931127: strange test class files
- Next message: Code Review: 6223635 Code hangs at connect call even when Timeout is specified when using a socks proxy
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi All,
This patch fixes a problem where the socks proxy implementation does not honor the timeout specified in Socket.connect(SocketAddress, timeout). In fact, it uses the read timeout set with setSoTimeout since the socks implementation opens a connection to the socks server to perform the socks protocol. This also violates the spec since a timeout of 0 means block indefinitely.
It is worth noting that the proposed fix changes the current behavior as specified above; SO_TIMEOUT no longer impacts on the timeout when using a socks proxy.
6223635: Code hangs at connect call even when Timeout is specified when using a socks proxy
OpenJDK Bugzilla ID: https://bugs.openjdk.java.net/show_bug.cgi?id=100130
Webrev: http://cr.openjdk.java.net/~chegar/6223635/webrev.00/webrev/
Contribution-by: damjan.jov at gmail.com
Thanks, -Chris.
- Previous message: hg: jdk7/tl/langtools: 6931127: strange test class files
- Next message: Code Review: 6223635 Code hangs at connect call even when Timeout is specified when using a socks proxy
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]