Code Review 6933618: java/net/MulticastSocket/NoLoopbackPackets.java fails when rerun (original) (raw)

Alan Bateman Alan.Bateman at Sun.COM
Wed Mar 10 04:32:43 PST 2010

Christopher Hegarty - Sun Microsystems Ireland wrote:

Hi Alan, Michael,

Trivial change. 6933618: java/net/MulticastSocket/NoLoopbackPackets.java fails when rerun If java/net/MulticastSocket/NoLoopbackPackets.java is run in a batch which contains all the MulticastSocket tests then it will fail on reruns with java.lang.NoSuchMethodError: Sender.. The reason it fails is that there is another test, java/net/MulticastSocket/SetOutgoingIf.java, that has a class named Sender. This test is typically run after NoLoopbackPackets so its Sender class gets left over in the classes directory and is used in subsequest runs of NoLoopbackPackets. The Sender class in NoLoopbackPackets is not compatible with the Sender class in SetOutgoingIf. NoLoopbackPackets should define Sender as an internal class avoiding this name conflict. Also remove hardcoded port number. Webrev: http://cr.openjdk.java.net/~chegar/6933618/webrev.00/ Thanks, -Chris. Looks okay to me - one small suggestion is to close msock in a finally block so that the file descriptor usage doesn't creep up during these samevm runs.

-Alan.

More information about the net-dev mailing list