Code Review 6934054: java/net/Socket/FDClose.java return error in samevm (original) (raw)

Christopher Hegarty -Sun Microsystems Ireland Christopher.Hegarty at Sun.COM
Thu Mar 11 07:50:16 PST 2010

Alan Bateman wrote:

..... I'm tempted to suggest that the best thing is to just hg rm the test as it's not very useful. If you want to keep it then the changes looks OK

This had crossed my mind. If you agree then I think I will just remove it.

-Chris.

to me. One suggestion is to have AReader implement Closeable and have the close implement just do sock.close().

-Alan.

More information about the net-dev mailing list