Code Review 6937703: java/net regression test issues with samevm (original) (raw)

Christopher Hegarty - Sun Microsystems Ireland Christopher.Hegarty at Sun.COM
Wed Mar 24 04:32:06 PDT 2010

On 24/03/2010 11:06, Alan Bateman wrote:

Christopher Hegarty - Sun Microsystems Ireland wrote:

Hi Michael, Alan,

Some more test updates for samevm mode. Webrev: http://cr.openjdk.java.net/~chegar/6937703/webrev.00/webrev/ -Chris. In HttpTest.java I see exceptions are silently consumed - while you are there it would be good to at least print the stack trace to may any future failures easier to debug. Good catch with the wrong header in B5052093.java. An alternative for this one is to put the try/finally after you assign server. That would avoid needing to catch if it null or not.

Thanks Alan,

I've made the changes you suggested and updated the webrev.

-Chris.

Otherwise looks good to me and thanks for fixing up these issues. -Alan.

More information about the net-dev mailing list