Code Review 7025938: Add bitmap mime type to content-types.properties (original) (raw)
Alan Bateman Alan.Bateman at oracle.com
Thu Aug 18 10:03:04 PDT 2011
- Previous message: Code Review 7025938: Add bitmap mime type to content-types.properties
- Next message: Code Review 7025938: Add bitmap mime type to content-types.properties
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Chris Hegarty wrote:
Can I get a review for this contribution?
It adds bitmap mime type support to content-types.properties, so that URLConnection.getContentType() returns 'image/bmp' rather than 'content/unknown'. This is not a commonly used API, but the contribution seems reasonable. I agree with the change, just cannot be a reviewer of my own commits! When you are pushing a change-set that lists someone else in the Contributed-by field then you can be the reviewer. I've done this a few times. In any case, I think this change is okay too.
-Alan.
diff -r af15e902cf08 src/solaris/lib/content-types.properties --- a/src/solaris/lib/content-types.properties Wed Aug 10 12:30:29 2011 +0100 +++ b/src/solaris/lib/content-types.properties Thu Aug 18 17:36:31 2011 +0100 _@@ -225,6 +225,10 @@ image/png: _ _icon=png;_ action=browser _+image/bmp: _ _+ description=Bitmap Image;_ + fileextensions=.bmp; + _text/html: _ _description=HTML Document;_ _fileextensions=.htm,.html;_ diff -r af15e902cf08 src/windows/lib/content-types.properties --- a/src/windows/lib/content-types.properties Wed Aug 10 12:30:29 2011 +0100 +++ b/src/windows/lib/content-types.properties Thu Aug 18 17:36:31 2011 +0100 _@@ -222,6 +222,10 @@ image/png: _ _icon=png;_ action=browser _+image/bmp: _ _+ description=Bitmap Image;_ + fileextensions=.bmp; + _text/html: _ _description=HTML Document;_ _fileextensions=.htm,.html;_ -Chris.
- Previous message: Code Review 7025938: Add bitmap mime type to content-types.properties
- Next message: Code Review 7025938: Add bitmap mime type to content-types.properties
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]