Question about getaddrinfo in Inet4AddressImpl.c (original) (raw)

Chris Hegarty chris.hegarty at oracle.com
Tue Nov 8 11:25:59 PST 2011

Charles,

Is it possible to fix up the style issues, etc that Neil pointed out, and have the webrev updated?

Thanks, -Chris.

On 11/ 8/11 01:44 PM, Charles Lee wrote:

On 11/03/2011 12:33 AM, Neil Richards wrote:

On Wed, 2011-11-02 at 23:07 +0800, Charles Lee wrote:

On 10/26/2011 06:31 PM, Chris Hegarty wrote:

On 26/10/2011 10:36, Alan Bateman wrote:

On 26/10/2011 10:24, Charles Lee wrote:

/>>> I don't think this code has changed too much since then and probably could do with a clean-up./ Not true. I'm talking about the InetAddress* code, that hasn't changed significantly and probably could do with some modernization now. Yes, please submit a patch for this cleanup and we'll review it. -Chris. -Alan. Hi Chris, Alan and Neil, Here is the rest of the patch (attached). The patch is a little big because some formats. For ease of review, I've uploaded this change (ie. the combination of Charles' 'patch.contr.v1' and 'patch.contr.part2') as a webrev [1]. My initial (and picky) observation is that the code indentation needs a little work to comply with the OpenJDK coding conventions [2]. (Particularly using a standard indentation for 4 spaces). Regards, Neil [1] http://cr.openjdk.java.net/~ngmr/ojdk-229/webrev.00/ [2] http://www.oracle.com/technetwork/java/codeconventions-150003.pdf Hi guys, Apart from the code convention issues, would anyone help to review the patch? It's kind of big patch :-)

More information about the net-dev mailing list