Fwd: Re: Suppress creation of SocksSocketImpl in SocketAdaptor's constructor (original) (raw)
Chris Hegarty chris.hegarty at oracle.com
Mon Nov 21 02:02:37 PST 2011
- Previous message: Fwd: Re: Suppress creation of SocksSocketImpl in SocketAdaptor's constructor
- Next message: hg: jdk8/tl/hotspot: 8 new changesets
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 19/11/2011 19:44, Alan Bateman wrote:
On 18/11/2011 10:57, Chris Hegarty wrote:
Hi Kris,
I think this change should be fine, but I would like Alan to comment also. I looked at it in more detail and I think it should okay. Will you sponsor it? My only comment on the change is the catching of SocketException causes a RuntimeException to be thrown but that is inconsistent with other areas of this code where AssertionError or InternalError is thrown.
Yes, I can sponsor this change. And yes, I agree InternalError would be better.
-Chris.
-Alan
- Previous message: Fwd: Re: Suppress creation of SocksSocketImpl in SocketAdaptor's constructor
- Next message: hg: jdk8/tl/hotspot: 8 new changesets
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]