Crash due to missing synchronization on 'gconf_client' in 'jdk/src/solaris/native/sun/net/spi/DefaultProxySelector.c' (original) (raw)
Alan Bateman Alan.Bateman at oracle.com
Fri Aug 10 09:28:42 PDT 2012
- Previous message: Crash due to missing synchronization on 'gconf_client' in 'jdk/src/solaris/native/sun/net/spi/DefaultProxySelector.c'
- Next message: Crash due to missing synchronization on 'gconf_client' in 'jdk/src/solaris/native/sun/net/spi/DefaultProxySelector.c'
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 10/08/2012 17:10, Chris Hegarty wrote:
Christian,
I finally got back to this. Since init() is only ever called from the class initializer it is implicitly single threaded, so we only need to add the synchronized keyword to getSystemProxy(). I also added a test for completeness. Here is the final webrev that I intend to push ( listing 'Christian Schulte <cs at schulte.it>' as the contributor ). http://cr.openjdk.java.net/~chegar/7188755/webrev.00/webrev/ -Chris. The change looks good to me. The test is fine took although I assume if any of the threads through an exception then it will not cause the test to fail (but of course if they crash it will).
-Alan
- Previous message: Crash due to missing synchronization on 'gconf_client' in 'jdk/src/solaris/native/sun/net/spi/DefaultProxySelector.c'
- Next message: Crash due to missing synchronization on 'gconf_client' in 'jdk/src/solaris/native/sun/net/spi/DefaultProxySelector.c'
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]