RFR JDK-4880778 (original) (raw)

Alan Bateman Alan.Bateman at oracle.com
Sat Feb 2 08:29:42 PST 2013

On 02/02/2013 14:39, John Zavgren wrote:

Greetings:

Please consider the following modification of our classes for handling URLs. http://cr.openjdk.java.net/~jzavgren/4880778/webrev.01/ This looks okay to me.

For the URLStreamHandler setURL methods then an alternative to removing the statement would be just adjust the wording, say replace "be able to call the set method on a URL" to "be able to use this method to set the values of the URL fields".

Minor nit, but there are couple of alignment issues. In URL then the arguments spill onto 2 or 3 lines so they can be re-aligned. In URLStreamHandler it look slike the setURL method isn't quite lined up with the other methods (pre-dates your proposed changes).

-Alan.

More information about the net-dev mailing list