RFR 8008223: java/net/BindException/Test.java fails rarely (original) (raw)
Alan Bateman Alan.Bateman at oracle.com
Fri Feb 15 01:54:58 PST 2013
- Previous message: RFR 8008223: java/net/BindException/Test.java fails rarely
- Next message: hg: jdk8/tl/langtools: 8006225: tools/jdeps/Basic.java failes with AssertionError
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 15/02/2013 09:51, Chris Hegarty wrote:
On 15/02/2013 08:18, Alan Bateman wrote: .... I guess this is assuming that their the tests are run with -ea or that the presence of the assert will keep the reference alive. Would it be The presence of the asserts will keep the reference alive even if running without asserts enabled. But it is not ideal.
better to just have a finally block that closes the sockets (from a brief look it doesn't appear that this test cleans up anyway). Right. This is much cleaner. http://cr.openjdk.java.net/~chegar/8008223/webrev.01/webrev/ This is much better, looks good to me.
-Alan
- Previous message: RFR 8008223: java/net/BindException/Test.java fails rarely
- Next message: hg: jdk8/tl/langtools: 8006225: tools/jdeps/Basic.java failes with AssertionError
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]