Code Review Request: 7044870: TEST_BUG: java/nio/channels/DatagramChannel/SelectWhenRefused.java failed on SUSE Linux 10 (original) (raw)
Alan Bateman Alan.Bateman at oracle.com
Thu Aug 25 07:33:04 PDT 2011
- Previous message: Code Review Request: 7044870: TEST_BUG: java/nio/channels/DatagramChannel/SelectWhenRefused.java failed on SUSE Linux 10
- Next message: Code Review Request: 7044870: TEST_BUG: java/nio/channels/DatagramChannel/SelectWhenRefused.java failed on SUSE Linux 10
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Kurchi Hazra wrote:
Hi,
The update code with some more styling/comment changes: The patch looks okay to me. Minor nit is that the comments should keep the existing style. Also these tests rarely use DatagramSocket and where they do then they use "ds" rather than "sock". Otherwise thanks for taking this one.
-Alan.
-------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20110825/38e26dd5/attachment.html
- Previous message: Code Review Request: 7044870: TEST_BUG: java/nio/channels/DatagramChannel/SelectWhenRefused.java failed on SUSE Linux 10
- Next message: Code Review Request: 7044870: TEST_BUG: java/nio/channels/DatagramChannel/SelectWhenRefused.java failed on SUSE Linux 10
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]