Code review request: 7068616 NIO libraries do not build with javac -Xlint:all,-deprecation -Werror (original) (raw)

Alan Bateman Alan.Bateman at oracle.com
Thu Jul 28 08🔞58 PDT 2011

Alexandre Boulgakov wrote:

Hello everyone,

Please review these NIO changes. Bug detail: http://bugs.sun.com/bugdatabase/viewbug.do?bugid=7068616 <http://bugs.sun.com/bugdatabase/viewbug.do?bugid=7068616> webrev: http://cr.openjdk.java.net/~alanb/7068616/webrev/ Most of the changes are one-line fixes to remove warnings, and I've updated the make files to flag warnings as errors from now on, ignoring deprecation warnings in sun.io.*. I also revised some of the try-catch blocks to make use of multicatch syntax. There are two larger changes in src/solaris/classes/sun/nio/ch/SctpChannelImpl.java and src/solaris/classes/sun/nio/ch/SctpMultiChannelImpl.java, where I changed a private inner class from "private class InternalNotificationHandler extends AbstractNotificationHandler" to "private class InternalNotificationHandler extends AbstractNotificationHandler" because it was not using the type variable T. AbstractNotificationHandler is consistent with the original behavior where InternalNotificationHandler was used as a raw type. Thanks, Sasha Thanks for doing this. It's okay to ignore sun.io as that be likely be removed from jdk8 soon (the legacy sun.io converters have been death row for many releases).

The changes seem okay to me. Minor nit in sun/nio/ch/Reflect.java is that the parameters to lookupConstructor are no longer aligned. Also I assume you've verified that it builds on all platforms as this area has platform specific classes.

-Alan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20110728/7cff0caf/attachment.html

More information about the nio-dev mailing list