7191556: (fs) UnixNativeDispatcher.getextmntent should be moved into platform specific code (original) (raw)

Alan Bateman Alan.Bateman at oracle.com
Wed Aug 15 07:36:17 PDT 2012

On 15/08/2012 15:18, Andrew Hughes wrote:

: This looks good to me and built ok here.

My only concern is that this now means that Macs now always get a null file type detector, whereas there might have been a working one if glib was installed. The name "GNOMEFileTypeDetector" is a bit of a misnomer as GIO is part of glib, which is intentionally multi-platform (even Windows, I believe). Maybe worth asking on the BSD and Mac lists? It might motivate them to provide a solution using the native Mac API (assuming there is one) ;-) Thanks, Thanks Andrew.

There are a few things still missing on Mac, a FileTypeDetector is one. I don't know common it is to have GIO on the Mac but I would prefer that there would be separate change-set to add support for file type detector on the Mac (if that's okay with you). Once there is an implementation then it would plug-in by overriding getFileTypeDetector in MacOSXFileSystemProvider.

On GnomeFileTypeDetector then it is so named because it started out by using GNOME VFS, it got GIO support later. It should probably be separated out now. Maybe this is something you would like to take on?

-Alan

More information about the nio-dev mailing list