request for review: 7184932: Remove the temporary Selector usage in the NIO socket adapters (original) (raw)

Alan Bateman Alan.Bateman at oracle.com
Thu Aug 16 04:53:08 PDT 2012

On 15/08/2012 22:09, Rob McKenna wrote:

Hi folks,

Looking for a codereview of this change. Basically we're looking to avoid the use of temporary selectors in socket adapters. This should result in resource usage improvements for users who make extensive use of these adapters in multiple threads. http://cr.openjdk.java.net/~robm/7184932/webrev.02/ <http://cr.openjdk.java.net/%7Erobm/7184932/webrev.02/> Thanks, -Rob This looks like good progress since the last round.

DatagramSocketAdaptor.receive - I think this needs to check for POLLIN rather than dc.isConnected.

DatagramChannelImpl.poll - are you missing the reset of readerThread? Same thing in ServerSocketChannelImpl.poll.

ServerSocketAdaptor.accept - shouldn't this be POLLIN rather than POLLCONN?

Minor nit in src/windows/native/sun/nio/ch/Net.c where the indenting should be 4-spaces.

In src/solaris/native/sun/nio/ch/Net.c then the changes are okay although given the existing assumptions on the values of POLL* then you could return pfd.revents.

I haven't gone through the test yet but I will get to it when I get time.

-Alan.

-------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20120816/013e3490/attachment.html

More information about the nio-dev mailing list