Code Review Request: 7168172: (fs) Files.isReadable slow on Windows (original) (raw)
Alan Bateman Alan.Bateman at oracle.com
Fri Aug 24 01:04:16 PDT 2012
- Previous message: Code Review Request: 7168172: (fs) Files.isReadable slow on Windows
- Next message: Code Review Request: 7168172: (fs) Files.isReadable slow on Windows
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 23/08/2012 22:17, Kurchi Hazra wrote:
Here is an updated webrev: http://cr.openjdk.java.net/~khazra/7168172/webrev.01/ I left the booleans as it is, but removed the modes.length() check. This looks good to me and thanks for taking Ulf's comment to avoid needing to check is modes has 0 elements.
-Alan.
- Previous message: Code Review Request: 7168172: (fs) Files.isReadable slow on Windows
- Next message: Code Review Request: 7168172: (fs) Files.isReadable slow on Windows
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]