Fwd: Remove including of link.h to improve portability (original) (raw)

Chris Hegarty chris.hegarty at oracle.com
Fri Mar 16 03:21:41 PDT 2012

Charles,

Not a big deal, but since Jonathan is an author for the jdk8 project you can create the changeset with his OpenJDK username, then you won't need the "Contributed-by" field.

hg commit -u luchsh ....

Or Jonathan can create the changeset and use 'hg export' to create a patch for you to 'hg import'.

-Chris.

On 16/03/2012 02:53, Charles Lee wrote:

Hi Jonathan,

The changeset @ Changeset: c4e66dc3222d Author: littlee Date: 2012-03-16 10:47 +0800 URL:http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c4e66dc3222d 7153343: Dependency on non-POSIX header file<link.h> causes portability problem Summary: Remove the unneccessary link.h Reviewed-by: alanb, chegar Contributed-by: Jonathan Lu<luchsh at linux.vnet.ibm.com>

Please verify it. On 03/16/2012 10:18 AM, Jonathan Lu wrote: On 03/15/2012 10:42 PM, Chris Hegarty wrote: On 15/03/12 07:17, Jonathan Lu wrote: On 03/13/2012 06:25 PM, Alan Bateman wrote:

On 13/03/2012 10:21, Jonathan Lu wrote:

Hi Alan,

With Phil's advice, I've splitted the original patch into two parts and created another bug for TL repository, bug 7153343. And here's the rebased patch based on TL repository. http://cr.openjdk.java.net/~luchsh/7153343/jdk.patch Could you please take a look? It looks okay to me. -Alan Thanks Alan! Can anybody else please help to take a look at the patch? The source changes look fine. I ran some fresh builds and tests, all pass fine and no (new) warnings. I see you are an author for jdk8. Will Charles be pushing this for you, or do you want me too? -Chris. Regards - Jonathan Lu Hi Chris, Thanks for review, I'll ask Charles to help to push the change. Regards - Jonathan

More information about the nio-dev mailing list