Review Request - JDK-6720349: (ch) Channels tests depending on hosts inside Sun (original) (raw)

Alan Bateman Alan.Bateman at oracle.com
Mon Nov 5 07:46:13 PST 2012

On 05/11/2012 13:47, Daniel Fuchs wrote:

Hi Alan,

Thanks for reviewing. I will make the changes and send another webrev when they are ready. Do I need a second reviewer? Or is one reviewer enough? For the jdk repo then one reviewer is fine.

:

Will do. If I add a new file next to TestUtil, I won't have to modify any makefile right? No need to change any make files.

- In Alias then the comment about Solaris should probably be replaced with a comment to say that the connection is established immediately. It looks as if this is platform specific. On Mac OS - (10.7.5) - the behavior was as the text expected. On Solaris - the connection was established immediately. On windows I don't remember what I observed. I can replace "On Solaris" with "On some platforms". Thanks.

-Alan

More information about the nio-dev mailing list