Code review request: 7105940, Test regression: KeyStore must be from provider SunPKCS11-NSSKeyStore (original) (raw)

Weijun Wang weijun.wang at oracle.com
Fri Oct 28 14:05:01 UTC 2011

Oh, really? On my Linux it's always ignored.

What did you mean "When run the test manually"? javac and java it?

Anyway, the fix is correct. You can putback it.

Thanks Max

On 10/28/2011 09:55 PM, Xuelei Fan wrote:

Move forward the @run tag, so that it can be really ignored by @ignore tag. Otherwise, it will be run as normal. That's also why I can catch the exception.

Thanks, Xuelei On 10/28/2011 9:53 PM, Weijun Wang wrote: CipherTest looks fine. What is the change in ClientJSSEServerJSSE for? Maybe you meant to remove the @ignore line?

Thanks Weijun

On 10/28/2011 09:19 PM, Xuelei Fan wrote: Hi Weijun, Would you please review my fix for 7105940(Test regression: KeyStore must be from provider SunPKCS11-NSSKeyStore)? webrev: http://cr.openjdk.java.net/~xuelei/7105940/webrev.00/ Thanks, Xuelei

More information about the security-dev mailing list